clippy fix

src/main.rs

@@ -157,7 +157,7 @@ impl cosmic::Application for App {
         input: Self::Flags,
     ) -> (Self, Task<Self::Message>) {
         debug!("init");
-        let mut nav_model = nav_bar::Model::default();
+        let nav_model = nav_bar::Model::default();
 
         let mut windows = vec![];
 
@@ -308,7 +308,6 @@ impl cosmic::Application for App {
                 let tooltip = tooltip(button,
                                       text::body(item.kind.to_string()),
                                       TPosition::Right);
-                let dragged_item = &self.library_dragged_item;
                 dnd_destination(tooltip, vec!["application/service-item".into()])
                     .data_received_for::<ServiceItem>( move |item| {
                         if let Some(item) = item {
@@ -600,11 +599,11 @@ impl cosmic::Application for App {
             }
             Message::Present(message) => {
                 // debug!(?message);
-                if self.presentation_open {
-                    if let Some(video) = &mut self.presenter.video {
+                if self.presentation_open
+                    && let Some(video) = &mut self.presenter.video
+                {
                     video.set_muted(false);
                 }
-                }
                 match self.presenter.update(message) {
                     presenter::Action::Task(task) => task.map(|m| {
                         // debug!("Should run future");
@@ -888,8 +887,9 @@ impl cosmic::Application for App {
                 // debug!(?action);
                 // debug!(?service_item);
 
-                if let Some(library) = &self.library {
-                    if let Some((lib, item)) = library.dragged_item {
+                if let Some(library) = &self.library
+                    && let Some((lib, item)) = library.dragged_item
+                {
                     // match lib {
                     //     core::model::LibraryKind::Song => ,
                     //     core::model::LibraryKind::Video => todo!(),
@@ -903,7 +903,6 @@ impl cosmic::Application for App {
                         .text(item.title.clone())
                         .data(item);
                 }
-                }
                 Task::none()
             }
             Message::AddLibrary(library) => {
@@ -933,8 +932,8 @@ impl cosmic::Application for App {
                     .iter()
                     .enumerate()
                     .find(|(id, _)| index == *id)
+                    && let Some(slide) = item.slides.first()
                 {
-                    if let Some(slide) = item.slides.first() {
                     self.current_item = (index, 0);
                     self.presenter.update(
                         presenter::Message::SlideChange(
@@ -942,7 +941,6 @@ impl cosmic::Application for App {
                         ),
                     );
                 }
-                }
                 Task::none()
             }
             Message::AddServiceItem(index, item) => {

src/ui/library.rs

@@ -1,5 +1,3 @@
-use std::rc::Rc;
-
 use cosmic::{
     iced::{
         alignment::Vertical, clipboard::dnd::DndAction,
@@ -394,7 +392,7 @@ impl<'a> Library {
                             )
                                 .action(DndAction::Copy)
                                 .drag_icon({
-                                    let model = model.kind.clone();
+                                    let model = model.kind;
                                     move |i| {
                                         let state = State::None;
                                         let icon = match model {

src/ui/presenter.rs

@@ -9,20 +9,17 @@ use cosmic::{
         Background, Border, Color, ContentFit, Font, Length, Shadow,
         Vector,
     },
-    iced_core::text::Span,
     iced_widget::{
         rich_text,
         scrollable::{
             scroll_to, AbsoluteOffset, Direction, Scrollbar,
         },
-        span, stack,
-        text::Rich,
-        vertical_rule,
+        span, stack, vertical_rule,
     },
     prelude::*,
     widget::{
-        container, horizontal_space, image, mouse_area, responsive,
-        scrollable, text, Column, Container, Id, Row, Space,
+        container, image, mouse_area, responsive, scrollable, text,
+        Column, Container, Id, Row, Space,
     },
     Task,
 };
@@ -32,11 +29,7 @@ use tracing::{debug, error, info, warn};
 use url::Url;
 
 use crate::{
-    core::{
-        service_items::{Service, ServiceItem},
-        slide::Slide,
-    },
-    ui::text_svg::{self, Font as SvgFont},
+    core::{service_items::ServiceItem, slide::Slide},
     // ui::widgets::slide_text,
     BackgroundKind,
 };

src/ui/song_editor.rs

@@ -7,12 +7,11 @@ use cosmic::{
         Font, Length,
     },
     iced_wgpu::graphics::text::cosmic_text::fontdb,
-    iced_widget::{row, stack},
+    iced_widget::row,
     theme,
     widget::{
-        button, column, combo_box, container, dropdown,
-        horizontal_space, icon, scrollable, svg::Handle, text,
-        text_editor, text_input, Svg,
+        button, column, combo_box, container, horizontal_space, icon,
+        scrollable, text, text_editor, text_input,
     },
     Element, Task,
 };
@@ -179,12 +178,12 @@ impl SongEditor {
                     .filter(|f| f.1 == font)
                     .map(|f| f.0)
                     .next();
-                if let Some(id) = font_id {
-                    if let Some(face) = self.font_db.face(id) {
+                if let Some(id) = font_id
+                    && let Some(face) = self.font_db.face(id)
+                {
                     self.font = face.post_script_name.clone();
                     // self.current_font = Font::from(face);
                 }
-                }
                 self.font = font.clone();
 
                 let font_name = font.into_boxed_str();
@@ -425,8 +424,9 @@ order",
     }
 
     fn background_video(&mut self, background: &Option<Background>) {
-        if let Some(background) = background {
-            if background.kind == BackgroundKind::Video {
+        if let Some(background) = background
+            && background.kind == BackgroundKind::Video
+        {
             let video =
                 Video::try_from(background).ok().map(|mut v| {
                     v.set_looping(true);
@@ -436,7 +436,6 @@ order",
             self.video = video;
         }
     }
-    }
 }
 
 impl Default for SongEditor {

src/ui/text_svg.rs

@@ -10,7 +10,7 @@ use cosmic::{
         Length, Size,
     },
     prelude::*,
-    widget::{container, lazy, responsive, svg::Handle, Svg},
+    widget::{container, svg::Handle, Svg},
 };
 use tracing::error;
 
@@ -330,7 +330,7 @@ mod test {
 
     #[test]
     fn test_text_spans() {
-        let mut text = TextSvg::new();
+        let mut text = TextSvg::new("yes");
         text.text = "This is
 multiline
 text."