chris/lumina
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

update todo.org with video times and refactoring ideas

Browse source
This commit is contained in:
Chris Cochrun 2024-04-10 09:48:59 -05:00
parent 461d25a73d
commit 0a895e1f04
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
TODO.org
View file

@ -4,9 +4,16 @@
:CATEGORY: dev :CATEGORY: dev
:END: :END:
* Tasks [64%] [53/82] * Tasks [63%] [53/83]
** TODO [#B] start and end times for videos :feature: ** TODO [#B] start and end times for videos :feature:
This is something I couldn't get right in my head and plans and I hope rust will help me to solve it. This is something I couldn't get right in my head and plans and I hope rust will help me to solve it.
I've got a sorta working concept. It hinges on MPV's --start and --end properties. We'll use this to make sure the video has the right settings. But, when switching to another video, we'll need to reset it.
It does reset, but doesn't if the video we are switching to is the same video, but different start and end times. This could be problematic if the user wanted to have two sections of the same video loaded. For say a teaching moment or something like that.
** TODO Refactor service_item_model.rs and slide_model.rs
I've been thinking about my design of the service item model and slide model classes and believe I've used way too many properties for these models than is necessary. Instead I would really only need to have the title, type, and ids of the various items in the other models, then find a way to look them up when requesting them for the slide_object.
** TODO [#B] Fix updating things in the song editor ** TODO [#B] Fix updating things in the song editor
[[file:~/dev/lumina/src/qml/presenter/SongEditor.qml::function updateLyrics(lyrics) {]] [[file:~/dev/lumina/src/qml/presenter/SongEditor.qml::function updateLyrics(lyrics) {]]
The core problem with this is that when we set the song, the index to get the item is the index of the item in the vector, not the ID in the DB. So, when we get a song, we can't use that index to update things, we need to make sure we are using the id so that all the new work in updating the right item is done correctly. The core problem with this is that when we set the song, the index to get the item is the index of the item in the vector, not the ID in the DB. So, when we get a song, we can't use that index to update things, we need to make sure we are using the id so that all the new work in updating the right item is done correctly.