clippy warnings down to 250 when using pedantic, nursery, and perf

src/ui/song_editor.rs

@@ -167,6 +167,10 @@ impl Display for Face {
         f: &mut std::fmt::Formatter<'_>,
     ) -> std::fmt::Result {
         let name = self.0.families[0].0.clone().trim().to_string();
+
+        // leaving this lint so we can make changes to what is "normal"
+        // font weight in the future, though I doubt we will
+        #[allow(clippy::wildcard_in_or_patterns)]
         let weight = match self.0.weight.0 {
             0..=100 => " Thin",
             101..=200 => " Extra Light",
@@ -177,6 +181,7 @@ impl Display for Face {
             801..=1000 => " Black",
             301..=500 | _ => "",
         };
+
         let style = match self.0.style {
             fontdb::Style::Normal => "",
             fontdb::Style::Italic => " Italic",
@@ -1423,7 +1428,7 @@ impl SongEditor {
                         )
                     })
                 }),
-                |i| Message::UpdateStrokeSize(i),
+                Message::UpdateStrokeSize,
             )
             .gap(5.0),
         ]
@@ -1501,7 +1506,7 @@ impl SongEditor {
                     })
                 })
             }),
-            |i| Message::UpdateShadowSize(i),
+            Message::UpdateShadowSize,
         )
         .gap(5.0);
 
@@ -1519,7 +1524,7 @@ impl SongEditor {
                     )
                 })
             }),
-            |i| Message::UpdateShadowOffsetX(i),
+            Message::UpdateShadowOffsetX,
         )
         .gap(5.0);
 
@@ -1537,7 +1542,7 @@ impl SongEditor {
                     )
                 })
             }),
-            |i| Message::UpdateShadowOffsetY(i),
+            Message::UpdateShadowOffsetY,
         )
         .gap(5.0);
 

src/ui/text_svg.rs

@@ -498,10 +498,8 @@ impl TextSvg {
         resvg::render(&resvg_tree, transform, &mut pixmap.as_mut());
         // debug!("rendered");
 
-        if cache {
-            if let Err(e) = pixmap.save_png(&path) {
-                error!(?e, "Couldn't save a copy of the text");
-            }
+        if cache && let Err(e) = pixmap.save_png(&path) {
+            error!(?e, "Couldn't save a copy of the text");
         }
 
         // debug!("saved");