chris/lumina
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[lint]: Ensure that it is clear Arc::clones are just cloning pointers

Browse source
This commit is contained in:
Chris Cochrun 2026-04-14 10:32:41 -05:00
parent fb14180e15
commit 7c82503510
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/core/songs.rs
View file

@ -1347,11 +1347,11 @@ You saved my soul"
pub async fn fill_db(db: Arc<SqlitePool>) -> Result<()> {
let mut songs = Vec::new();
for _ in 0..20 {
songs = add_song(songs, db.clone()).await?;
songs = add_song(songs, Arc::clone(&db)).await?;
let mut song = test_song();
let last_song = songs.last().expect("Should be here");
song.id = last_song.id;
songs = update_song(song, songs, db.clone()).await?;
songs = update_song(song, songs, Arc::clone(&db)).await?;
}
Ok(())
}
@ -1359,11 +1359,11 @@ You saved my soul"
#[tokio::test]
async fn song_db_and_model() {
let db = Arc::new(add_db().await.expect("ERROR OPENING"));
if let Err(e) = fill_db(db.clone()).await {
if let Err(e) = fill_db(Arc::clone(&db)).await {
panic!("grrr {e}")
};
let song_model = Model::new_song_model(db.clone()).await;
let song_model = Model::new_song_model(Arc::clone(&db)).await;
let length = song_model.items.len();
assert!(song_model.items.len() == 20, "Length is {length}");
let ids: Vec<i32> =
@ -1402,7 +1402,7 @@ You saved my soul"
async fn test_song_from_db() {
let song = test_song();
let db = Arc::new(add_db().await.unwrap());
if let Err(e) = fill_db(db.clone()).await {
if let Err(e) = fill_db(Arc::clone(&db)).await {
panic!("grrr {e}")
};
let result = get_song_from_db(7, db).await;
@ -1423,13 +1423,13 @@ You saved my soul"
#[tokio::test]
async fn test_update() {
let db = Arc::new(add_db().await.unwrap());
if let Err(e) = fill_db(db.clone()).await {
if let Err(e) = fill_db(Arc::clone(&db)).await {
panic!("grrr {e}")
};
let song = test_song();
let cloned_song = song.clone();
let mut song_model: Model<Song> = model().await;
song_model.load_from_db(db.clone()).await;
song_model.load_from_db(Arc::clone(&db)).await;
let test_song = song_model.get_item(2);
assert_ne!(test_song, Some(&cloned_song));

2
src/ui/library.rs
View file

@ -1470,7 +1470,7 @@ mod test {
#[tokio::test]
async fn test_library_add() -> Result<()> {
let db = Arc::new(add_db().await?);
fill_db(db.clone()).await?;
fill_db(Arc::clone(&db)).await?;
let mut library = Library::new(db).await;
let pre_length = library.song_library.items.len();
library.selected_items = Some(vec![(LibraryKind::Song, 5)]);