chris/lumina
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixing some small code smells

Browse source
This commit is contained in:
Chris Cochrun 2022-09-19 16:45:58 -05:00
parent 8b9bcd5a89
commit c2c26bddaf
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
TODO.org
View file

@ -3,16 +3,13 @@
:CATEGORY: dev :CATEGORY: dev
:END: :END:
* Tasks [50%] [14/28] * Tasks [53%] [15/28]
** TODO add a dropping area in the library :feature:ui: ** TODO add a dropping area in the library :feature:ui:
** TODO bug in dragging servicelist items to reorder. Maybe I can fix with me simplified model system :bug: ** TODO bug in dragging servicelist items to reorder. Maybe I can fix with me simplified model system :bug:
** TODO VideoSQL Model and SQLite system needs fixing :bug: ** TODO VideoSQL Model and SQLite system needs fixing :bug:
[[file:src/videosqlmodel.cpp::if (!query.exec("CREATE TABLE IF NOT EXISTS 'videos' ("]] [[file:src/videosqlmodel.cpp::if (!query.exec("CREATE TABLE IF NOT EXISTS 'videos' ("]]
** TODO Bug in mpv race condition with selecting with the presenter but not with the actual PresentationWindow. :bug:
when selecting an item in the ServiceList, if the PresentationWindow isn't visible, it seems to prompt mpv to show a window of it's own with the video playing if the item contains a video.
** TODO Build out a slide preview system so we can see each slide in the song or image slideshow :ui: ** TODO Build out a slide preview system so we can see each slide in the song or image slideshow :ui:
[[file:~/dev/church-presenter/src/qml/presenter/SongEditor.qml::Presenter.SlideEditor {]] [[file:~/dev/church-presenter/src/qml/presenter/SongEditor.qml::Presenter.SlideEditor {]]
@ -83,6 +80,9 @@ This thread helped a lot
** DONE images and videos need a better get system ** DONE images and videos need a better get system
[[file:~/dev/church-presenter/src/videosqlmodel.cpp::QVariantList VideoSqlModel::getVideo(const int &row) {]] [[file:~/dev/church-presenter/src/videosqlmodel.cpp::QVariantList VideoSqlModel::getVideo(const int &row) {]]
** DONE Bug in mpv race condition with selecting with the presenter but not with the actual PresentationWindow. :bug:
when selecting an item in the ServiceList, if the PresentationWindow isn't visible, it seems to prompt mpv to show a window of it's own with the video playing if the item contains a video.
** DONE Find a way to maths the textsize :slide: ** DONE Find a way to maths the textsize :slide:
[[file:~/dev/church-presenter/src/qml/presenter/Slide.qml::property real textSize: 50]] [[file:~/dev/church-presenter/src/qml/presenter/Slide.qml::property real textSize: 50]]

2
src/qml/presenter/MainWindow.qml
View file

@ -192,7 +192,7 @@ Controls.Page {
presentation.loadVideo(); presentation.loadVideo();
print("For window: Screen is: " + pWindow.screen + " And selected screen is: " + presentationScreen); print("For window: Screen is: " + pWindow.screen + " And selected screen is: " + presentationScreen);
pWindow.showFullScreen(); pWindow.showFullScreen();
pWindow.screen = presentationScreen; /* pWindow.screen = presentationScreen; */
print("For window: Screen is: " + pWindow.screen + " And selected screen is: " + presentationScreen); print("For window: Screen is: " + pWindow.screen + " And selected screen is: " + presentationScreen);
} }
else else

2
src/qml/presenter/PresentationWindow.qml
View file

@ -34,7 +34,7 @@ Window {
id: presentationSlide id: presentationSlide
anchors.fill: parent anchors.fill: parent
imageSource: SlideObject.imageBackground imageSource: SlideObject.imageBackground
videoSource: presentationWindow.visible ? SlideObject.videoBackground : null videoSource: presentationWindow.visible ? SlideObject.videoBackground : ""
text: SlideObject.text text: SlideObject.text
} }