diff --git a/justfile b/justfile index 7a05941..7a00a1c 100644 --- a/justfile +++ b/justfile @@ -26,7 +26,7 @@ watch-clippy: test: cargo nextest run ci-test: - cargo nextest run -- --skip test_db_and_model --skip test_update --skip test_song_slide_speed --skip test_song_to_slide --skip test_song_from_db + cargo nextest run -- --skip test_db_and_model --skip test_update --skip test_song_slide_speed --skip test_song_to_slide --skip test_song_from_db --skip song_search bench: export NEXTEST_EXPERIMENTAL_BENCHMARKS=1 cargo nextest bench diff --git a/src/core/song_search.rs b/src/core/song_search.rs index 3e63819..97b00f8 100644 --- a/src/core/song_search.rs +++ b/src/core/song_search.rs @@ -464,7 +464,7 @@ mod test { let mapped_song = Song::from(new_song); dbg!(&mapped_song); if let Some(map) = mapped_song.verse_map.as_ref() { - assert!(map.len() > 0); + assert!(!map.is_empty()); // Need to leave commented until I work on more robust tests. assert!( map.keys() @@ -511,10 +511,11 @@ mod test { Ok(()) } + #[allow(dead_code)] fn online_song_to_song(song: OnlineSong) -> Result<(), String> { let song = Song::from(song); if let Some(verse_map) = song.verse_map.as_ref() { - if verse_map.len() < 1 { + if verse_map.is_empty() { return Err(format!( "VerseMap wasn't built right likely: {song:?}", ));