chris/lumina
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[fix]: missing test skip for ci
Some checks failed
/ clippy (push) Successful in 5m32s
Details
/ test (push) Failing after 6m12s
Details

Browse source
This commit is contained in:
Chris Cochrun 2026-04-22 11:48:04 -05:00
parent e91a6795e4
commit dd2bbc2a0a
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
justfile
View file

@ -26,7 +26,7 @@ watch-clippy:
test:
cargo nextest run
ci-test:
cargo nextest run -- --skip test_db_and_model --skip test_update --skip test_song_slide_speed --skip test_song_to_slide --skip test_song_from_db
cargo nextest run -- --skip test_db_and_model --skip test_update --skip test_song_slide_speed --skip test_song_to_slide --skip test_song_from_db --skip song_search
bench:
export NEXTEST_EXPERIMENTAL_BENCHMARKS=1
cargo nextest bench

5
src/core/song_search.rs
View file

@ -464,7 +464,7 @@ mod test {
let mapped_song = Song::from(new_song);
dbg!(&mapped_song);
if let Some(map) = mapped_song.verse_map.as_ref() {
assert!(map.len() > 0);
assert!(!map.is_empty());
// Need to leave commented until I work on more robust tests.
assert!(
map.keys()
@ -511,10 +511,11 @@ mod test {
Ok(())
}
#[allow(dead_code)]
fn online_song_to_song(song: OnlineSong) -> Result<(), String> {
let song = Song::from(song);
if let Some(verse_map) = song.verse_map.as_ref() {
if verse_map.len() < 1 {
if verse_map.is_empty() {
return Err(format!(
"VerseMap wasn't built right likely: {song:?}",
));